Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add memory cache backend #7048

Merged
merged 3 commits into from
Jun 28, 2024
Merged

feat: add memory cache backend #7048

merged 3 commits into from
Jun 28, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

See #7047 for details

Usage

For repository scans (and filesystem/SBOM), it's used by default now.

$ trivy repo my-repo

For container image scans, you can specify this if you don't need cache.

$ trivy image debian:11 --cache-backend memory

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 27, 2024
@knqyf263 knqyf263 force-pushed the feat/memory_cache branch from 0888384 to 5ab9ccf Compare June 27, 2024 18:28
knqyf263 added 2 commits June 27, 2024 22:49
@knqyf263
feat(cache): add memory backend
f97bc11 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
docs: generate CLI references
2039525 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the feat/memory_cache branch from 5ab9ccf to 2039525 Compare June 27, 2024 18:49
@knqyf263
fix: ignore ExternalReferences for hashstructure
3714c80 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review June 28, 2024 06:25
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner June 28, 2024 06:25
DmitriyLewen
DmitriyLewen reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left one improvement

pkg/flag/cache_flags.go Show resolved Hide resolved
@knqyf263 knqyf263 added this pull request to the merge queue Jun 28, 2024
Merged via the queue into aquasecurity:main with commit 55ccd06 Jun 28, 2024
17 checks passed
@knqyf263 knqyf263 deleted the feat/memory_cache branch June 28, 2024 09:59
@aqua-bot aqua-bot mentioned this pull request Jun 28, 2024
Merged
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
@knqyf263 @skahn007gl
feat: add memory cache backend (aquasecurity#7048)
5f9394a 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add memory cache backend for improved scan efficiency
2 participants
@knqyf263 @DmitriyLewen