Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(golang): do not trim v prefix from versions #7711

Closed
knqyf263 opened this issue Oct 10, 2024 Discussed in #7709 · 1 comment · Fixed by #7733
Closed

fix(golang): do not trim v prefix from versions #7711

knqyf263 opened this issue Oct 10, 2024 Discussed in #7709 · 1 comment · Fixed by #7733
Assignees
@Rutam21
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.57.0

Comments

@knqyf263
Copy link
Collaborator

knqyf263 commented Oct 10, 2024 •
edited
Loading

Description

the go mod analyzer should not remove the v prefix from versions to get aligned with the go binary analyzer.

Discussed in #7709
@knqyf263 knqyf263 added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 10, 2024
@Rutam21
Copy link
Contributor

Rutam21 commented Oct 10, 2024

@knqyf263 I would like to work on this. Please assign this issue to me. Thanks.

@Rutam21 Rutam21 mentioned this issue Oct 14, 2024
Merged
1 task
@knqyf263 knqyf263 added this to the v0.57.0 milestone Oct 24, 2024
@knqyf263 knqyf263 mentioned this issue Oct 24, 2024
Closed
@macedogm macedogm mentioned this issue Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rutam21 Rutam21

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Trivy Roadmap
Status: No status
Milestone
v0.57.0
Development

Successfully merging a pull request may close this issue.

fix(go): Do not trim v prefix from versions in Go Mod Analyzer Rutam21/trivy
3 participants
@knqyf263 @Rutam21 and others