Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): ignore white space in pom.xml files #7747

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat(parser): ignore white space in pom.xml files #7747

merged 4 commits into from
Oct 17, 2024

Conversation

sgaist
Copy link
Contributor

@sgaist sgaist commented Oct 15, 2024

Description

This PR modifies the pom.xml parser so that the content of the fields are trimmed. It makes the parser behave in the same manner as maven.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

knqyf263
knqyf263 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd wait for @DmitriyLewen as he has more knowledge around Maven.

DmitriyLewen
DmitriyLewen approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgaist thanks for your work!
LGTM

cc. @knqyf263

@DmitriyLewen
Copy link
Contributor

hm... tests didn't start...
@sgaist Can you rebase this PR?

sgaist added 4 commits October 17, 2024 10:54
@sgaist
feat(parser): ignore white space in pom.xml files
1f9dfa3 
It happens when creating the data structures and does not
modify the file itself. It makes the parser behave in the
same manner as maven.

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
refactor(pom): ensure all fields are trimmed
8ba7b54 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
chore(pom): add properties to white space test
164a7c4 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
fix(pom): fix white space test file
a8a9d26 
The property was not correctly used.

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist sgaist force-pushed the 7658-trim-spaces-loading-pom branch from 69b587d to a8a9d26 Compare October 17, 2024 08:58
@knqyf263 knqyf263 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into aquasecurity:main with commit a7baa93 Oct 17, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(java): trim spaces from pom.xml fields
3 participants
@sgaist @DmitriyLewen @knqyf263