Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): handle git@github.com schema for misconfigs in sarif report #7898

Merged
merged 7 commits into from
Nov 14, 2024
Merged

fix(report): handle git@github.com schema for misconfigs in sarif report #7898

merged 7 commits into from
Nov 14, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

Overwrite git@github.com schema for misconfigs in sarif report.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 11, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 11, 2024 05:06
nikpivkin
nikpivkin reviewed Nov 13, 2024
View reviewed changes
pkg/report/sarif.go Outdated Show resolved Hide resolved
@nikpivkin nikpivkin self-requested a review November 13, 2024 09:51
@DmitriyLewen DmitriyLewen mentioned this pull request Nov 14, 2024
Closed
@knqyf263 knqyf263 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into aquasecurity:main with commit 19aea4b Nov 14, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Nov 11, 2024
Merged
@DmitriyLewen DmitriyLewen deleted the fix-sarif/github-schema branch November 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

@simar7 simar7 Awaiting requested review from simar7

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(sarif): we need to handle schema for URI's for misconfig
3 participants
@DmitriyLewen @nikpivkin @knqyf263