Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double success panel when using Frame #558

Open
luisivan opened this issue Jan 8, 2019 · 4 comments
Open

Double success panel when using Frame #558

luisivan opened this issue Jan 8, 2019 · 4 comments

Comments

@luisivan
Copy link
Contributor

luisivan commented Jan 8, 2019

Describe the bug
Frame creates a success transition when a transaction is broadcast, and it is extremely similar to the one on the Aragon client, resulting in a pretty awkward moment when using the product.

To Reproduce
Steps to reproduce the behavior:

  1. Install Frame
  2. Sign a transaction

Expected behavior
Detect if the client is not using MetaMask or is using Frame, and don't show the success panel.

@jounih
Copy link

jounih commented Feb 27, 2019

@bpierre can we detect when Frame is used instead of MetaMask?

@sohkai
Copy link
Contributor

sohkai commented Feb 27, 2019

@jounih This is somewhat difficult to do right now (see #621), but once we figure out how to do this we can disable this panel for frame.

Alternatively we could whitelist providers, like Metamask, and only the panel if they're connected.

@sohkai
Copy link
Contributor

sohkai commented Apr 2, 2019

This and #621 are now possible with web3.eth.getNodeInfo() in newer versions of web3.js (still undocumented).

@sohkai sohkai added the blocked label May 18, 2019
@stale stale bot added the abandoned label Nov 14, 2019
@aragon aragon deleted a comment from stale bot Nov 18, 2019
@stale stale bot removed the abandoned label Nov 18, 2019
@sohkai sohkai removed the blocked label Mar 18, 2020
@sohkai
Copy link
Contributor

sohkai commented Mar 18, 2020

I believe this should be detectable now, if the user uses frame without its extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants