Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate on deployment script to prevent registering non existent repos #169

Open
0xGabi opened this issue Nov 21, 2019 · 4 comments
Open
Labels
bug Something isn't working

Comments

@0xGabi
Copy link
Contributor

0xGabi commented Nov 21, 2019

The script currently registers each repo involved in the deployment process that was not already registered on the aragonPM registry by default. The particular line of code that does that: here

This is an issue cause the registration data is malformed and provoke the following RPC error: Error: Invalid JSON RPC response: ""

@0xGabi 0xGabi added the bug Something isn't working label Nov 21, 2019
@sohkai
Copy link
Contributor

sohkai commented Nov 21, 2019

The problem is, the templates need these repos to exist before they can work.

We should either provide an empty repo here, or handle the RPC error elsewhere.

@0xGabi
Copy link
Contributor Author

0xGabi commented Nov 22, 2019

So are we able to provide an empty repo object so the RPC request keep working? Otherwise I don’t think users will be able to publish new versions of their templates even if we handle the RPC error

@sohkai
Copy link
Contributor

sohkai commented Nov 22, 2019

Otherwise I don’t think users will be able to publish new versions of their templates even if we handle the RPC error

Why wouldn't this be the case? Publishing the template repos shouldn't depend at all on any previously published app repos.

@0xGabi
Copy link
Contributor Author

0xGabi commented Nov 22, 2019

The problem is with the repo of the template itself. The current script also registers the repo for the template been deployed so the content of that repo becomes malformed. Then when trying to publish a new version (e.i actually publishing the template by the user) the RPC is not able to fetch the repo causing the above error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants