Decoupling the VPU from the VGIC. #12
Replies: 3 comments 2 replies
-
Also we need to decouple the gic from the VGIC. |
Beta Was this translation helpful? Give feedback.
-
As for the first question, I agree with you. We can discard the original For GICH, I think your opinion is right. We should remove the GICH implementation in arm_gic crate and implement it in the vgic crate instead. |
Beta Was this translation helpful? Give feedback.
-
There's another problem. I think Solution 1 is very likely to be reasonable. But we need change something in arceos ... |
Beta Was this translation helpful? Give feedback.
-
There are three important structs in vgics.rs : (currently,only considering v2)VgicInt , VgicCpuPriv , Vgic.
The latter two both contain VgicInt, it's defination as follows:
`struct VgicIntInnerMut {
owner: Option,
in_lr: bool,
lr: u16,
enabled: bool,
state: IrqState,
prio: u8,
targets: u8,
cfg: u8,
}`
I carefully checked every “owner” the whole file,they only use attr 'id', so why not use a "u32: id" or something else...
Beta Was this translation helpful? Give feedback.
All reactions