Add mode parameter to symlink #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2020
leemhenson
force-pushed
the
symlink-mode
branch
from
08dbbb0
to
12209ae
Compare
ctalkington
approved these changes
Nov 19, 2020
ctalkington
added
the
enhancement
ctalkington
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently opened these PRs:
#468
archiverjs/node-zip-stream#68
But I had a rethink and I think this is a better approach. It just exposes the mode as an optional argument to
symlink. Setting the mode to493for directory symlinks does exactly what I need, and also allows other users to control the permissions however they want.