Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation and source code mismatch for finalize #481

Closed
Nowadays opened this issue Dec 15, 2020 · 0 comments · Fixed by #482
Closed

Documentation and source code mismatch for finalize #481

Nowadays opened this issue Dec 15, 2020 · 0 comments · Fixed by #482

Comments

@Nowadays
Copy link

See https://github.com/archiverjs/node-archiver/blob/master/lib/core.js#L770

It's not mentionned anywhere that finalize actually returns a Promise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix finalize method jsdoc return type archiverjs/node-archiver
1 participant
@Nowadays