Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractLinks running slowly #123

Closed
greebie opened this issue Nov 29, 2017 · 2 comments
Closed

ExtractLinks running slowly #123

greebie opened this issue Nov 29, 2017 · 2 comments

Comments

@greebie
Copy link
Contributor

greebie commented Nov 29, 2017

After running unit tests, scripts that use ExtractLinks may be running slower than need be. The primary reason is that it is using Python libraries instead of the java core.
@greebie
Copy link
Contributor Author

greebie commented Nov 29, 2017

Testing a intermediary fix by changing the for loop to a list comprehension (after reading that comprehensions are faster than maps in most cases).

@ianmilligan1
Copy link
Member

Continued in #130 (just making it more specific). 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greebie @ianmilligan1