Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractDomain mistakenly checks source first then url #277

Closed
borislin opened this issue Oct 16, 2018 · 0 comments
Closed

ExtractDomain mistakenly checks source first then url #277

borislin opened this issue Oct 16, 2018 · 0 comments
Assignees

Comments

@borislin
Copy link
Collaborator

Describe the bug
ExtractDomain mistakenly checks source first then url.

To Reproduce
Steps to reproduce the behavior:

  1. Fix unit test by updating the data2 variable in ExtractDomainTest to be the following:
    private val data2 = Seq.newBuilder.+=( (index, "http://www.umiacs.umd.edu/~jimmylin/", umiacs), ("https://github.com/lintool", "http://www.umiacs.umd.edu/~jimmylin/", "github.com"), (index, "https://github.com/lintool", "github.com")).result()
  2. Run mvn clean package
  3. See error and build fails

Expected behavior
mvn clean package should not produce any error after fixing the unit test ExtractDomainTest. Build should succeed.

Environment information

  • AUT version: HEAD
  • OS: tuna
  • Java version: Java 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants