ExtractDomain or ExtractBaseDomain?

[lintool]

In Scala RDD, we have:

import io.archivesunleashed._
import io.archivesunleashed.matchbox._

RecordLoader.loadArchives("src/test/resources/warc/example.warc.gz", sc).keepValidPages()
  .map(r => ExtractDomain(r.getUrl))
  .countItems()
  .take(10)

In Scala DF, we have:

import io.archivesunleashed._
import io.archivesunleashed.df._

RecordLoader.loadArchives("src/test/resources/warc/example.warc.gz", sc).extractValidPagesDF()
  .select(ExtractBaseDomain($"Url").as("Domain"))
  .groupBy("Domain").count().orderBy(desc("count"))
  .show(20, False)

We should be consistent: ExtractDomain or ExtractBaseDomain?

[ruebot]

Let's go with ExtractDomain.

[ruebot]

Shall we just rename it to ExtractDomainDF (in the interim period between moving migrating all the RDDs to DFs)?

aut/src/main/scala/io/archivesunleashed/df/package.scala

Line 34 in e32ae17

val ExtractBaseDomain = udf(io.archivesunleashed.matchbox.ExtractDomain.apply(_: String, ""))

[lintool]

Any reason why you want the DF suffix?
I suppose there's the potential for confusion, but I like the beauty of uniformity...

[ruebot]

Oh, just keeping it consistent with how we've done the same with the other DF functions like here

aut/src/main/scala/io/archivesunleashed/package.scala

Line 115 in e32ae17

def extractHyperlinksDF(): DataFrame = {

...I'm happy to keep it uniform too.

[lintool]

Although per #366 we would rename that to just hyperlinks? To make consistent with Python?

[lintool]

Okay, so stick to ExtractDomain?