Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in ArcTest? Why run RemoveHTML? #369

Closed
lintool opened this issue Oct 26, 2019 · 1 comment
Closed

Bug in ArcTest? Why run RemoveHTML? #369

lintool opened this issue Oct 26, 2019 · 1 comment

Comments

@lintool
Copy link
Member

lintool commented Oct 26, 2019

https://github.com/archivesunleashed/aut/blob/master/src/test/scala/io/archivesunleashed/ArcTest.scala#L105

Extract:

val mimeTypeCounts = RecordLoader.loadArchives(arcPath, sc)
      .map(r => RemoveHTML(r.getContentString))
      .groupBy(content => DetectMimeTypeTika(content.getBytes))
      .map(f => {
        (f._1, f._2.size)
      }).collect

Shouldn't RemoveHTML be RemoveHttpHeader?
@lintool lintool mentioned this issue Oct 26, 2019
Merged
@lintool
Copy link
Member Author

lintool commented Nov 5, 2019

Video chat with @ruebot and @ianmilligan1 - conclusion - this indeed is a bug.

@ruebot ruebot closed this as completed in 6686519 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lintool