Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant Maintenance Secret #757

Closed
aeq-dev opened this issue Nov 18, 2021 · 4 comments
Closed

Tenant Maintenance Secret #757

aeq-dev opened this issue Nov 18, 2021 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@aeq-dev
Copy link

aeq-dev commented Nov 18, 2021

Description

Same as the main domain where we can enable maintenance with secret key in order to access to the app for admins for example,
is there a way to do that for tenant's admins

Why this should be added

Give the ability to tenant's admins to access to the app

@aeq-dev aeq-dev added the feature New feature or request label Nov 18, 2021
@stein-j
Copy link
Contributor

stein-j commented Dec 3, 2021

From what I can understand: The package doesn't uses the Laravel default maintenance mode, which doesn't surprises me because the way Laravel handle it is not tenant compatible.
This means this package would have to fully recreate Laravel maintenance mode, which could work... but not all features would be doable (like the --render option because this allows the render a page before Laravel boots, but for tenancy you need to boot Laravel).

Small idea/lead:
When Laravel is in maintenance mode, it can "except" routes defined in PreventRequestsDuringMaintenance middleware. Maybe the package could utilise this to use Laravel down feature and still allow some tenant. Though, I'm not convinced this is the best idea.

@stancl
Copy link
Member

stancl commented Dec 25, 2021

In which case would some tenants be in maintenance mode, but others not?

@stancl stancl closed this as completed Dec 25, 2021
@stein-j
Copy link
Contributor

stein-j commented Dec 25, 2021

@stancl to answer your question, I think there are many use case :

  • A tenant that is used as a demo which is often reset, it needs to be put in maintenance mode temporally and alone
  • You have a big update and want to put then into maintenance mode one by once instead of denying access to all tenants too long
  • You have a tenant used for testing and do not want people to access it while you are working on it
  • etc.

@stancl
Copy link
Member

stancl commented Dec 25, 2021

Right, I expressed myself poorly. I meant, in which case would some tenants be in maintenance mode, but others not, with a need for access via the URL secret.

For example the "You have a big update and want to put then into maintenance mode one by once instead of denying access to all tenants too long" point is just selective tenant maintenance mode. And the first point probably doesn't need a secret.

I can see why having some tenant accessible only for testing is good though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants