Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control over importing behavior #16

Closed
kbrandwijk opened this issue Dec 18, 2017 · 7 comments
Closed

More control over importing behavior #16

kbrandwijk opened this issue Dec 18, 2017 · 7 comments

Comments

@kbrandwijk
Copy link
Contributor

kbrandwijk commented Dec 18, 2017

Proposal (based on #13, #14 and #15):

Add optional parameter to importSchema:

rules? : {
   removeUnusedTypes?: boolean = true,
   importAllInterfaceImplementations?: boolean = false,
   importMissingTypes?: boolean = true,
   orderTypes?: boolean = false,
   strict?: boolean = true,
   validate?: boolean = false
}

Most are self-explanatory, strict: true would fail on missing schema files or missing imported types, otherwise silently ignored. validate: true would run the linter.

@schickling
Copy link
Contributor

That looks good. Would be great if you could update your proposal to include default values.

@kbrandwijk
Copy link
Contributor Author

@schickling Done.

@kbrandwijk kbrandwijk self-assigned this Jan 6, 2018
@ccnixon
Copy link

ccnixon commented Jan 26, 2018

Hey guys - any plans on taking a look at this in the near term? My use case:

I'm hoping to use graphql-s2s type inheritance in tandem with import statements but the validation step is failing. It would be great to be able to set a flag to bypass the validation step and and just compile the schema. Thanks!

@raeesaa
Copy link

raeesaa commented Feb 7, 2018

I am having similar use case as @ccnixon. It would be great to have an option to bypass schema validation.

@kbrandwijk Any ETA for this issue?

@raeesaa
Copy link

raeesaa commented Feb 21, 2018

@kbrandwijk Any updates on this?

@DavidStummer
Copy link

@kbrandwijk we would love this too

@ardatan
Copy link
Owner

ardatan commented Mar 17, 2020

Available in 1.0.0!

@ardatan ardatan closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants