Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Types not registried correctly if it only nested in other Object type #825

Closed
ole3021 opened this issue Jun 1, 2018 · 3 comments
Closed

Comments

@ole3021
Copy link

ole3021 commented Jun 1, 2018

Hi, guys, I currently fond an issue with the type registry in the stitching lib.

The bug is if some basic type(Float i tested) are not used in the root of Query type, but used only in some nested my own Object Type, then during the stitching there would have a problem of Error: No such type: Float. You can test it out or I will add some code to reproduction this bug later.

Maybe I can make some PR as well if I got time.

Looking for this bug fixed.

@ghost ghost added blocking Prevents production or dev due to perf, bug, build error, etc.. bug feature New addition or enhancement to existing solutions labels Jun 1, 2018
@hwillson
Copy link
Contributor

hwillson commented Sep 7, 2018

A small runnable reproduction here would be greatly appreciated. Thanks!

@hwillson hwillson added needs-reproduction and removed blocking Prevents production or dev due to perf, bug, build error, etc.. bug feature New addition or enhancement to existing solutions labels Sep 7, 2018
@grantwwu
Copy link

@hwillson I have created such a reproduction and linked it in #847, where it seems like some investigative work has already been done. Should we consolidate there?

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

mergeSchemas does not merge typedefs (!), it stitches them together by proxying. Merging can be done within makeExecutableSchema by just using an array of strings for typeDefs.

See #443 (comment)

Not sure if this addresses your issue. Please reopen with minimal reproducing repository if still relevant.

@yaacovCR yaacovCR closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants