Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial buffer size unchangeable #700

Open
maxgerhardt opened this issue Apr 2, 2023 · 3 comments
Open

Serial buffer size unchangeable #700

maxgerhardt opened this issue Apr 2, 2023 · 3 comments

Comments

@maxgerhardt
Copy link

Per #651 (comment).

Due to the #undef construct done in

#ifdef SERIAL_BUFFER_SIZE
#undef SERIAL_BUFFER_SIZE
#endif
#define SERIAL_BUFFER_SIZE 256

it's not possible to set a global -DSERIAL_BUFFER_SIZE=... value and have it be use used anymore.

A user has a usecase for that here.

@Muny
Copy link

Muny commented Jul 21, 2023

Agreed, it was pretty deleterious to add those.

@maxgerhardt
Copy link
Author

Still seems like the amount of people that care about this is exactly 0.

@Muny
Copy link

Muny commented Jul 21, 2023

Still seems like the amount of people that care about this is exactly 0.

I presume it's because the people who do care about it find ways to work around it. I ended up adding a pre-build step to my project to patch this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants