From 6fa9645d1408cbdf98e342bdb53e1ca95ba8ae58 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sun, 31 Jul 2022 15:30:54 -0700 Subject: [PATCH] [skip changelog] Enable Codecov comments on PRs from forks Versions of the `codecov/codecov-action` GitHub Actions action prior to 1.0.6 required the use of a token provided by Codecov in order to upload data to Codecov. This token was stored in secret in the Arduino CLI repository and used in the test workflow. For security reasons, secrets are not accessible when a workflow is triggered by an event generated by a fork of the repository. This meant that it was impossible to upload coverage data for the test runs triggered by PRs from forks. A conditional was added to the upload step of the workflow to cause it to only run on `push` event triggers, which effectively prevented its failure for runs on PRs from forks. The token requirement was removed in the 1.0.6 release of `codecov/codecov-action`, but the now pointless conditional was never removed from the workflow. This prevented PRs from forks from receiving the automated code coverage report comments that would otherwise encourage those contributors to resolve coverage deficiencies and facilitate the review process. The harmful conditional is hereby removed from the coverage data upload steps of the workflow and PRs from forks will now receive coverage report comments, just as PRs from branches do already. --- .github/workflows/test-go-task.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml index d8423d13b70..90df72399eb 100644 --- a/.github/workflows/test-go-task.yml +++ b/.github/workflows/test-go-task.yml @@ -98,9 +98,7 @@ jobs: run: task test-legacy - name: Send unit tests coverage to Codecov - if: > - runner.os == 'Linux' && - github.event_name == 'push' + if: runner.os == 'Linux' uses: codecov/codecov-action@v3 with: file: ./coverage_unit.txt @@ -108,9 +106,7 @@ jobs: fail_ci_if_error: ${{ github.repository == 'arduino/arduino-cli' }} - name: Send legacy tests coverage to Codecov - if: > - runner.os == 'Linux' && - github.event_name == 'push' + if: runner.os == 'Linux' uses: codecov/codecov-action@v3 with: file: ./coverage_legacy.txt