Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved changes are lost on "Language" preference change #954

Open
3 tasks done
per1234 opened this issue Apr 14, 2022 · 0 comments
Open
3 tasks done

Unsaved changes are lost on "Language" preference change #954

per1234 opened this issue Apr 14, 2022 · 0 comments
Assignees
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Apr 14, 2022

Describe the problem

The "Language" menu of the File > Preferences dialog now offers a selection of seven languages the Arduino IDE user interface can be localized to (#941).

🐛 Any unsaved changes to the sketch are lost after changing this preference.

To reproduce

  1. Select File > Preferences... from the Arduino IDE menus.
  2. Uncheck the box next to " Auto save".
  3. Click the OK button.
  4. Make some change to the sketch.
    ❗ Do not save the sketch.
  5. Select File > Preferences... from the Arduino IDE menus.
  6. Select a different language from the "Language" menu.
  7. Click the OK button.

🐛 The unsaved change to the sketch is lost when the IDE window reloads.

Expected behavior

Make the unsaved state of the sketch persist through the reload.

-OR-

Present the user with a standard save dialog before doing the reload.

Arduino IDE version

2.0.0-rc5-snapshot-a3640cf

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

I think this will occur for any preference that causes a reload on change, but I didn't find any others that have that behavior currently.


This was not introduced by #953. The unsaved changes were lost even with the reload method used before the change made in that PR.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants