Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mi32 legacy: improve parser #21648

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Mi32 legacy: improve parser #21648

merged 1 commit into from
Jun 16, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Jun 16, 2024

Description:

  • support for a few more data types - mainly to support the BLE button XMWXKG01LM (single/double/hold click and battery)
  • use the sensor name from a BTHome device (Probably temporary active scan with mi32option4 1 needed to catch it, then this name can be saved with mi32cfg. Can be overridden and will not override an already given name.)
  • refactoring some code sections

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit d15b88f into arendst:development Jun 16, 2024
59 checks passed
@Staars Staars deleted the mi32 branch July 11, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants