Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand basic UMD modules #146

Open
andrewbranch opened this issue Feb 20, 2024 · 1 comment
Open

Understand basic UMD modules #146

andrewbranch opened this issue Feb 20, 2024 · 1 comment

Comments

@andrewbranch
Copy link
Collaborator

https://unpkg.com/vue-chartkick@1.1.0/dist/vue-chartkick.js

@Tobbe
Copy link

Tobbe commented Feb 25, 2024

Support for UMD would be great!

I tried with this https://arethetypeswrong.github.io/?p=%40tobbe.dev%2Frsc-test%400.0.4
and I get
image

Is this the expected output for a ESM+UMD package?

UPDATE:

I made some changes to my packaging setup, and released a new version, 0.0.5.
https://arethetypeswrong.github.io/?p=%40tobbe.dev%2Frsc-test%400.0.5

image

So that looks better. But it would still be nice to have UMD support or, at least in the meantime, know what the expected output would be for attw when it encounters an UMD package

BTW – and I should have said this first – Thanks a lot for this tool! It's very helpful for the whole JS ecosystem! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants