You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current test suite is located within the saltproc folder, and does not make full use of some useful features of pytest (namely, fixtures and pytest.mark.parameterize). This will enable stronger error messages when tests fail. Additionally, there are inconsistencies between the some of the test input files and the content in the test suite that could be made consistent. There are also some hardcoded paths in test files that should be removed to avoid confusion
Description of idea
Move saltproc/test to tests
Remove cruft paths to avoid confusion
Refactor the test suite to make better use of the pytest package
Implementation details
Test cases and functions of interest are:
Using the @pytest.fixture decorator to declare Depcode, Simulation, and other objects in the _test.py cases
Using pytest.raises to test where the code should fail
Potential snags
This could require some major refactoring.
The text was updated successfully, but these errors were encountered:
yardasol
changed the title
Feature: Move test folder and make use of pytest.fixture and pytest.raises in the Test suite
Feature: Clean up test suite and make use of pytest.fixture and pytest.raises in the Test suite
Apr 26, 2022
Background and motivation
The current test suite is located within the
saltproc
folder, and does not make full use of some useful features ofpytest
(namely, fixtures andpytest.mark.parameterize
). This will enable stronger error messages when tests fail. Additionally, there are inconsistencies between the some of the test input files and the content in the test suite that could be made consistent. There are also some hardcoded paths in test files that should be removed to avoid confusionDescription of idea
saltproc/test
totests
pytest
packageImplementation details
Test cases and functions of interest are:
@pytest.fixture
decorator to declareDepcode
,Simulation
, and other objects in the_test.py
casespytest.raises
to test where the code should failPotential snags
This could require some major refactoring.
The text was updated successfully, but these errors were encountered: