Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Clean up test suite and make use of pytest.fixture and pytest.raises in the Test suite #155

Closed
yardasol opened this issue Apr 25, 2022 · 1 comment

Comments

@yardasol
Copy link
Contributor

yardasol commented Apr 25, 2022

Background and motivation

The current test suite is located within the saltproc folder, and does not make full use of some useful features of pytest (namely, fixtures and pytest.mark.parameterize). This will enable stronger error messages when tests fail. Additionally, there are inconsistencies between the some of the test input files and the content in the test suite that could be made consistent. There are also some hardcoded paths in test files that should be removed to avoid confusion

Description of idea

  1. Move saltproc/test to tests
  2. Remove cruft paths to avoid confusion
  3. Refactor the test suite to make better use of the pytest package

Implementation details

Test cases and functions of interest are:

  • Using the @pytest.fixture decorator to declare Depcode, Simulation, and other objects in the _test.py cases
  • Using pytest.raises to test where the code should fail

Potential snags

This could require some major refactoring.

@yardasol yardasol added this to the v0.5.0 milestone Apr 25, 2022
@yardasol yardasol mentioned this issue Apr 26, 2022
20 tasks
@yardasol yardasol changed the title Feature: Move test folder and make use of pytest.fixture and pytest.raises in the Test suite Feature: Clean up test suite and make use of pytest.fixture and pytest.raises in the Test suite Apr 26, 2022
@yardasol yardasol mentioned this issue Jul 28, 2022
17 tasks
@yardasol yardasol self-assigned this Aug 5, 2022
@yardasol
Copy link
Contributor Author

yardasol commented Jan 9, 2023

closed by #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant