Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cleanup depcode.py and related files #162

Closed
yardasol opened this issue Aug 5, 2022 · 0 comments · Fixed by #172
Closed

Feature: Cleanup depcode.py and related files #162

yardasol opened this issue Aug 5, 2022 · 0 comments · Fixed by #172
Assignees
Milestone

Comments

@yardasol
Copy link
Contributor

yardasol commented Aug 5, 2022

Background and motivation

I read a lot of code while working on OpenMC all summer and think we can clean up depcode.py and related files.

Description of idea

  • Refactor the current depcode.py into three different files:
    • abc.py : holds abstract base classses like Depcode
    • openmc_depcode.py : holds OpenMCDepcode class
    • serpent_depcode.py : holds SerpentDepcode class
  • Cleanup variable names, import statements, and docstrings

Implementation details

This should be fairly straightforward.

Potential snags

This could take longer than I think it might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant