Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused attributes and functions in Materialflow, Process, Reactor #168

Open
yardasol opened this issue Oct 12, 2022 · 0 comments
Open

Unused attributes and functions in Materialflow, Process, Reactor #168

yardasol opened this issue Oct 12, 2022 · 0 comments

Comments

@yardasol
Copy link
Contributor

yardasol commented Oct 12, 2022

The Materialflow, Process, and Reactor classes contains several attributes and functions that appear to be unused in the code. Specifically, the following attributes and functions are in question:
For Materialflow:

  • mass_flowrate
  • density
  • volume
  • temperature
  • get_mass()
  • __eq__
  • __add__

For Process:

  • capacity
  • volume'
  • check_mass_conservation()

For Reactor:

  • mass_flowrate
  • volume

The purpose and function of each of these attributes should be investigated, and a PR made that either removes or clarifies their purpose.

@yardasol yardasol changed the title Unused attributes in Materialflow, Process Unused attributes in Materialflow, Process, `Reactor Nov 1, 2022
@yardasol yardasol changed the title Unused attributes in Materialflow, Process, `Reactor Unused attributes in Materialflow, Process, Reactor Nov 1, 2022
@yardasol yardasol changed the title Unused attributes in Materialflow, Process, Reactor Unused attributes and functions in Materialflow, Process, Reactor Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant