You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Materialflow, Process, and Reactor classes contains several attributes and functions that appear to be unused in the code. Specifically, the following attributes and functions are in question:
For Materialflow:
mass_flowrate
density
volume
temperature
get_mass()
__eq__
__add__
For Process:
capacity
volume'
check_mass_conservation()
For Reactor:
mass_flowrate
volume
The purpose and function of each of these attributes should be investigated, and a PR made that either removes or clarifies their purpose.
The text was updated successfully, but these errors were encountered:
yardasol
changed the title
Unused attributes in Materialflow, Process
Unused attributes in Materialflow, Process, `Reactor
Nov 1, 2022
yardasol
changed the title
Unused attributes in Materialflow, Process, `Reactor
Unused attributes in Materialflow, Process, ReactorNov 1, 2022
yardasol
changed the title
Unused attributes in Materialflow, Process, Reactor
Unused attributes and functions in Materialflow, Process, ReactorNov 1, 2022
The
Materialflow
,Process
, andReactor
classes contains several attributes and functions that appear to be unused in the code. Specifically, the following attributes and functions are in question:For
Materialflow
:mass_flowrate
density
volume
temperature
get_mass()
__eq__
__add__
For
Process
:capacity
volume
'check_mass_conservation()
For
Reactor
:mass_flowrate
volume
The purpose and function of each of these attributes should be investigated, and a PR made that either removes or clarifies their purpose.
The text was updated successfully, but these errors were encountered: