Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of concerns #44

Closed
5 of 6 tasks
katyhuff opened this issue Feb 5, 2020 · 1 comment · Fixed by #98
Closed
5 of 6 tasks

Separation of concerns #44

katyhuff opened this issue Feb 5, 2020 · 1 comment · Fixed by #98

Comments

@katyhuff
Copy link
Member

katyhuff commented Feb 5, 2020

  • The simulation class should only know enough to do a small number of things specific to the simulation mangement.
  • The depcode class should not assume a particular depletion code choice. It should be a pure virtual class. #59
  • Other classes should implement the stuff that is specific to the depletion code chosen (these should be instances (which inherit from depcode) like a serpent2 class, an openmc class, etc.)
  • the geometry changing should be in its own file probably.
  • the template reading and writing should be closer to the depcode class (maybe in in the serpent class).
  • maybe the app class and the simulation class should be merged, then separated back out so that there is a separation of concern.
@yardasol
Copy link
Contributor

Upon further inspection of the code, it seems most of these have been completed tasks. @katyhuff @andrewryh can you confirm? May need to look at the code with @munkm to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment