Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logs RBAC enforcement by default #10551

Open
crenshaw-dev opened this issue Sep 8, 2022 · 4 comments
Open

Enable logs RBAC enforcement by default #10551

crenshaw-dev opened this issue Sep 8, 2022 · 4 comments
Labels
enhancement New feature or request security Security related
Milestone

Comments

@crenshaw-dev
Copy link
Member

Summary

In 2.4 we introduced new RBAC for logs. In 2.5, we should enable that enforcement by default as promised in the 2.3 -> 2.4 upgrade guide.

Motivation

We said we'd do it. :-)

Proposal

Set the flag to true by default, and add a note to the 2.4 -> 2.5 upgrade notes.

@crenshaw-dev crenshaw-dev added enhancement New feature or request security Security related labels Sep 8, 2022
@crenshaw-dev crenshaw-dev added this to the v2.5 milestone Sep 8, 2022
@crenshaw-dev
Copy link
Member Author

I think we should save this for 3.0.

Project-scoped roles can currently only hold RBAC for the applications resource. So this change would break logs for anyone who relies on a Project-scoped role implicitly granting logs access via applications, get.

@crenshaw-dev crenshaw-dev modified the milestones: v2.5, v3.0 Sep 9, 2022
@niqdev
Copy link
Contributor

niqdev commented Oct 30, 2022

I know that this is not enabled by default in 2.x, but after upgrading to argo-helm 5.8.7, I had to explicitly add p, role:admin, logs, get, */*, allow for the admin user to re-enable the logs.

Shouldn't this be added also to the admin by default?

@agaudreault
Copy link
Member

Project-scoped roles should support logs resource before this can be enabled by default IMO. It makes more sense to allow/deny logs within an application or project instead of globally. It also aligns with the principle of least privilege that is currently configurable in the Project resource.

@reggie-k
Copy link
Member

Actually, projects scoped roles already support logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security Security related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants