Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to combine helm values from multiple sources in the argocd application when using the vault plugin. #14521

Closed
anieo opened this issue Jul 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@anieo
Copy link

anieo commented Jul 15, 2023

Summary

argocd application should be able to take helm values from multiple sources and combine them together especially the plugin parameters with helm values.

Motivation

Currently, when using argocd-image-updater to update the docker image version, t creates a helm source that results in an error when using the argocd-vault-plugin. even when you don't use helm source. This limitation forces users to choose between using the write-back method or the vault plugin. By allowing the combination of helm values from multiple sources, users can benefit from both methods without facing any errors.

Proposal

the sidecar can replace the vault pointers from the plugin parameters first run the helm template command
helm can accept multiple values files that may override each other

You can specify the '--values'/'-f' flag multiple times. The priority will be given to the last (right-most) file specified.

you can give a way in the sidecar like a predefined variable that will always hold the helm_values, helm_files_1,helm_files_2,etc and the plugin_paramter that the user will define then the order form the sidecar definition.

i know that i am looking talking about the case of helm chart/repo. and i didn't conside the rest of the cases you need to consider with each change and that figuring out a solution that fits all is not easy.

Second Proposal

maybe this issue can be fixed from the image-updater side by integrating with plugins or giving the user a way to specify how to update the value.

Thank you very much

@crenshaw-dev
Copy link
Member

#12508 will provide a mechanism to do this

@anieo
Copy link
Author

anieo commented Jul 18, 2023

Thanks closing

@anieo anieo closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants