Forward git credentials to config management plugins

[stevendborrelli]

We've been experimenting with configuration management plugins and have come across an issue when connecting to authenticated repositories.

Could we do something similar to the kustomize code https://github.com/argoproj/argo-cd/blob/master/util/kustomize/kustomize.go#L118 and forward Git credentials to the config management plugins?

[alexec]

@stevendborrelli do you have repo steps please?

[alexmt]

I believe this is an enhancement not a bug. So there are no steps to reproduce. It definitely makes sense to support passing credentials to the config management plugins

[alexec]

@alexmt I'm not familiar with the plugin code, are you able to provide any pointers to code?

[jessesuen]

I had asked @stevendborrelli to file this issue in slack. Basically, we gave kustomize special treatment to set up a proper git environment whenever we run kustomize build, so that it could use its remote base feature.

Since users can additionally perform kustomize build as part of plugins, we need to extend this special treatment to custom plugins.

[jessesuen]

@alexmt I'm not familiar with the plugin code, are you able to provide any pointers to code?

Here is the feature which enabled forwarding git credentials to kustomize:

1d3ec93

[alexec]

Do we need to include SSH too? Out of scope?

[jessesuen]

SSH should be supported too. It should be easy to do once we support SSH kustomize remote bases.

[alexec]

SSH out of scope of this issue. See #827 instead.

[alexec]

Here is where the change needs to be made:

argo-cd/reposerver/repository/repository.go

Line 525 in d06303c

env := append(os.Environ(), fmt.Sprintf("%s=%s", PluginEnvAppName, q.AppLabelValue), fmt.Sprintf("%s=%s", PluginEnvAppNamespace, q.Namespace))

[alexec]

Closed. Will be in v1.1