Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme support auto mode #20105

Closed
linghaoSu opened this issue Sep 25, 2024 · 3 comments · Fixed by #20080
Closed

Theme support auto mode #20105

linghaoSu opened this issue Sep 25, 2024 · 3 comments · Fixed by #20080
Labels
component:settings RBAC issues/enhancements component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@linghaoSu
Copy link
Contributor

Summary

The Appearance Settings theme supports 'Auto mode, which will follow the OS theme settings.

Motivation

Wants the theme to be set automatically and to automatically change to a darker colour at night like the OS theme.
related comment

Suggestions

Browsers have matchMedia to help use listen to OS theme changes
@linghaoSu linghaoSu added the enhancement New feature or request label Sep 25, 2024
@linghaoSu linghaoSu mentioned this issue Sep 25, 2024
Merged
14 tasks
@reggie-k reggie-k added component:settings RBAC issues/enhancements component:ui User interfaces bugs and enhancements labels Sep 26, 2024
@todaywasawesome
Copy link
Contributor

Great idea and should be easy!

@bianbbc87
Copy link

That's a good idea, and I want to contribute to this issue 😃

@linghaoSu
Copy link
Contributor Author

That's a good idea, and I want to contribute to this issue 😃

@bianbbc87 I've implemented a pr for this enhancement. 🤔

#20080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:settings RBAC issues/enhancements component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): support auto theme linghaoSu/argo-cd
4 participants
@todaywasawesome @reggie-k @linghaoSu @bianbbc87