Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: Helm vs Git - configuration polish #2259

Open
alexec opened this issue Sep 6, 2019 · 5 comments
Open

Helm: Helm vs Git - configuration polish #2259

alexec opened this issue Sep 6, 2019 · 5 comments
Labels
component:settings RBAC issues/enhancements enhancement New feature or request type:tech-debt Enhancement invisible for the end user

Comments

@alexec
Copy link
Contributor

alexec commented Sep 6, 2019

Is your feature request related to a problem? Please describe.

Currently we have Git fields on Repository and have Type as a type-descrimitator. We could instead have a Git and a Helm field.
@alexec alexec added enhancement New feature or request helm labels Sep 6, 2019
@alexec alexec mentioned this issue Sep 6, 2019
Merged
@alexmt alexmt added this to the v1.3 milestone Sep 9, 2019
@alexec alexec assigned alexec and unassigned alexec Sep 9, 2019
@alexec alexec added the M label Sep 12, 2019
@alexec
Copy link
Contributor Author

alexec commented Sep 13, 2019

@alexmt @jessesuen not sure about this one. I don't think we should do this. It breaks backward compatibility for Git.

@alexmt
Copy link
Collaborator

alexmt commented Sep 15, 2019

I disagree. The helm.repositories is also breaking change. Since we decided to merge helm.repositories and repositories we should do it right. Support helm.repositories and repositories git only fields, depreated them and eventually drop.

@alexmt alexmt self-assigned this Sep 15, 2019
@alexec
Copy link
Contributor Author

alexec commented Oct 16, 2019

@alexmt can we close this?

@alexmt
Copy link
Collaborator

alexmt commented Oct 16, 2019

I would prefer to work on it in v1.4.

@alexec alexec modified the milestones: v1.3, v1.4 Oct 16, 2019
@alexec
Copy link
Contributor Author

alexec commented Oct 16, 2019

Move to v1.4

@alexec alexec removed the helm label Nov 22, 2019
@alexmt alexmt modified the milestones: v1.4, v1.5 Jan 23, 2020
@alexmt alexmt modified the milestones: v1.5, v1.6 Feb 18, 2020
@alexmt alexmt removed the M label May 13, 2020
@jannfis jannfis added component:settings RBAC issues/enhancements type:tech-debt Enhancement invisible for the end user labels May 14, 2020
@alexmt alexmt removed this from the v1.6 GitOps Engine milestone May 27, 2020
@alexmt alexmt removed their assignment Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:settings RBAC issues/enhancements enhancement New feature or request type:tech-debt Enhancement invisible for the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexmt @alexec @jannfis