Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UID number rather than username in Dockerfile #3520

Closed
wdullaer opened this issue Apr 30, 2020 · 3 comments
Closed

Use UID number rather than username in Dockerfile #3520

wdullaer opened this issue Apr 30, 2020 · 3 comments
Labels
component:distribution Manifests, docker files, CLI distrubution etc duplicate This issue or pull request already exists enhancement New feature or request type:usability Enhancement of an existing feature

Comments

@wdullaer
Copy link
Contributor

Summary

Set a numeric user in the docker file, rather than the argocd username.

Motivation

Kubernetes will reject the pod if the security context does not allow to run as root, because it can't validate that a named user isn't root.
See: kubernetes/kubernetes#56503

I know you can overwrite the uid with a securityContext directive, but it'd be nice if this worked out of the box.

Proposal

Change https://github.com/argoproj/argo-cd/blob/master/Dockerfile#L78
to

USER 999
@wdullaer wdullaer added the enhancement New feature or request label Apr 30, 2020
@jannfis
Copy link
Member

jannfis commented May 1, 2020

We already have a PR for this: #3108

@jannfis
Copy link
Member

jannfis commented May 1, 2020

And there is #2746

@jannfis jannfis added the duplicate This issue or pull request already exists label May 1, 2020
@wdullaer
Copy link
Contributor Author

wdullaer commented May 3, 2020

Nice to see it's already on the radar.
I did do a search through the issues, but apparently not thorough enough.

I'll be following the PR :-)

@jannfis jannfis added component:distribution Manifests, docker files, CLI distrubution etc type:usability Enhancement of an existing feature labels May 14, 2020
@rbreeze rbreeze closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:distribution Manifests, docker files, CLI distrubution etc duplicate This issue or pull request already exists enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants