-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argocd Application: Support kustomize patch values #8579
Comments
+1 |
Another use case: If someone uses the PR generator & Git generator against the same Kustomize overlay, they may wish to Currently you can do this by passing |
Another use case is to use kustomize to change ingress host which is currently not possible without a patch (kubernetes-sigs/kustomize#347).
Note: Ingress host |
Similar usecase to @r0bj, I would like to add annotations to existing objects. |
I think I'd wanna do this at the top level so you can apply patches to more than just Helm sources. |
I could imagine something like this, basically borrowing apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
name: myapps
spec:
generators:
- pullRequest:
github:
owner: myorg
repo: myrepository
template:
spec:
patches:
- target:
kind: Ingress
patch: |-
- op: replace
path: /spec/rules/0/host
value: '{{branch}}.example.com' |
@joebowbeer not exactly, I misspoke in my comment above saying #14646 was a PoC of my proposed spec. I think OP wants the patches to be able to apply to any source type, not just kustomize. Similar request here: #16352 |
This feature would help a lot! |
+1 |
Would love to see the |
Summary
What change you think needs making.
A new patching approach for arogcd Application with kustomize.
Motivation
Please give examples of your use case, e.g. when would you use this.
Managing many platforms that essentially use almost the same applications is somehow cumbersome with apps of apps pattern or via a helm chart. (We want to avoid DRY as mush as possible!)
Using kustomize to build a common base for all platforms is really better and consistent.
All our members should know the Application manifests very well, and thus can apply patches more easily.
Proposal
How do you think this should be implemented?
Adding a field to
ApplicationSourceHelm
so that kustomize users get the benifet of using it to apply patches.Check my demo repo: https://github.com/mcbenjemaa/argocd-apps
The text was updated successfully, but these errors were encountered: