Snyk test report
- - --
-
- /argo-cd/argoproj/argo-cd/v2/go.mod (gomodules) -
- /argo-cd/ui/yarn.lock (yarn) -
Prototype Pollution
-- - - -
- - -
Detailed paths
- - - -- -
Overview
-dompurify is a DOM-only XSS sanitizer for HTML, MathML and SVG.
-Affected versions of this package are vulnerable to Prototype Pollution due to improper user input sanitization through the depth-checking mechanism, an attacker can exploit this vulnerability by using special nesting techniques to create a malicious HTML file.
-Details
-Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
--
-
Unsafe
-Objectrecursive merge
- Property definition by path
-
-
Unsafe Object recursive merge
-The logic of a vulnerable recursive merge function follows the following high-level model:
-merge (target, source)
-
- foreach property of source
-
- if property exists and is an object on both the target and the source
-
- merge(target[property], source[property])
-
- else
-
- target[property] = source[property]
- - -
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
-There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
-There are a few methods by which Prototype Pollution can be manipulated:
-| Type | -Origin | -Short description | -
|---|---|---|
| Denial of service (DoS) | -Client | -This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
-
| Remote Code Execution | -Client | -Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
-
| Property Injection | -Client | -The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
-
Affected environments
-The following environments are susceptible to a Prototype Pollution attack:
--
-
Application server
-
- Web server
-
- Web browser
-
-
How to prevent
--
-
Freeze the prototype— use
-Object.freeze (Object.prototype).
- Require schema validation of JSON input.
-
- Avoid using unsafe recursive merge functions.
-
- Consider using objects without prototypes (for example,
-Object.create(null)), breaking the prototype chain and preventing pollution.
- As a best practice use
-Mapinstead ofObject.
-
For more information on this vulnerability type:
-Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
-Remediation
-Upgrade dompurify to version 2.5.4, 3.1.3 or higher.
References
- - -- - - -
Regular Expression Denial of Service (ReDoS)
-- - - -
- - -
Detailed paths
- - - -- -
Overview
-Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) when including multiple regular expression parameters in a single segment, which will produce the regular expression /^\/([^\/]+?)-([^\/]+?)\/?$/, if two parameters within a single segment are separated by a character other than a / or .. Poor performance will block the event loop and can lead to a DoS.
Note:
- While the 8.0.0 release has completely eliminated the vulnerable functionality, prior versions that have received the patch to mitigate backtracking may still be vulnerable if custom regular expressions are used. So it is strongly recommended for regular expression input to be controlled to avoid malicious performance degradation in those versions. This behavior is enforced as of version 7.1.0 via the strict option, which returns an error if a dangerous regular expression is detected.
Workaround
-This vulnerability can be avoided by using a custom regular expression for parameters after the first in a segment, which excludes - and /.
PoC
-/a${'-a'.repeat(8_000)}/a
- Details
-Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
-The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
-Let’s take the following regular expression as an example:
-regex = /A(B|C+)+D/
- This regular expression accomplishes the following:
--
-
AThe string must start with the letter 'A'
- (B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.
- DFinally, we ensure this section of the string ends with a 'D'
-
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
-$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
- 0.04s user 0.01s system 95% cpu 0.052 total
-
- $ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
- 1.79s user 0.02s system 99% cpu 1.812 total
- The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
-Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
-Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
--
-
- CCC -
- CC+C -
- C+CC -
- C+C+C. -
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
-From there, the number of steps the engine must use to validate a string just continues to grow.
-| String | -Number of C's | -Number of steps | -
|---|---|---|
| ACCCX | -3 | -38 | -
| ACCCCX | -4 | -71 | -
| ACCCCCX | -5 | -136 | -
| ACCCCCCCCCCCCCCX | -14 | -65,553 | -
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
-Remediation
-Upgrade path-to-regexp to version 0.1.10, 1.9.0, 3.3.0, 6.3.0, 8.0.0 or higher.
References
--
-
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- Strict Mode Release Note -
- Vulnerability Write-up -
- - - -
Denial of Service (DoS)
-- - - -
- - -
Detailed paths
- - - -- -
Overview
-Affected versions of this package are vulnerable to Denial of Service (DoS) through the processing of malicious preflight requests that include a Access-Control-Request-Headers header with excessive commas. An attacker can induce excessive memory consumption and potentially crash the server by sending specially crafted requests.
PoC
-
- func BenchmarkPreflightAdversarialACRH(b *testing.B) {
- resps := makeFakeResponses(b.N)
- req, _ := http.NewRequest(http.MethodOptions, dummyEndpoint, nil)
- req.Header.Add(headerOrigin, dummyOrigin)
- req.Header.Add(headerACRM, http.MethodGet)
- req.Header[headerACRH] = adversarialACRH
- handler := Default().Handler(testHandler)
-
- b.ReportAllocs()
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- handler.ServeHTTP(resps[i], req)
- }
- }
-
- var adversarialACRH []string
-
- func init() { // populates adversarialACRH
- n := int(math.Floor(math.Sqrt(http.DefaultMaxHeaderBytes)))
- commas := strings.Repeat(",", n)
- res := make([]string, n)
- for i := range res {
- res[i] = commas
- }
- adversarialACRH = res
- }
- Details
-Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
-Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
-One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
-When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
-Two common types of DoS vulnerabilities:
--
-
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
-
- Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
-wspackage
-
Remediation
-Upgrade github.com/rs/cors to version 1.11.0 or higher.
References
--
-
- GitHub Commit -
- GitHub Issue -
- GitHub PR -
- - - -
Concurrent Execution using Shared Resource with Improper Synchronization ('Race Condition')
-- - - -
- - -
Detailed paths
- - - -- -
Overview
-github.com/Azure/azure-sdk-for-go/sdk/azidentity is a module that provides Microsoft Entra ID (formerly Azure Active Directory) token authentication support across the Azure SDK. It includes a set of TokenCredential implementations, which can be used with Azure SDK clients supporting token authentication.
-Affected versions of this package are vulnerable to Concurrent Execution using Shared Resource with Improper Synchronization ('Race Condition') in the authentication process. An attacker can elevate privileges by exploiting race conditions during the token validation steps. This is only exploitable if the application is configured to use multiple threads or processes for handling authentication requests.
-Notes:
--
-
An attacker who successfully exploited the vulnerability could elevate privileges and read any file on the file system with SYSTEM access permissions;
-
- An attacker who successfully exploits this vulnerability can only obtain read access to the system files by exploiting this vulnerability. The attacker cannot perform write or delete operations on the files;
-
- The vulnerability exists in the following credential types:
-DefaultAzureCredentialandManagedIdentityCredential;
- The vulnerability exists in the following credential types:
-
-
ManagedIdentityApplication (.NET)
ManagedIdentityApplication (Java)
ManagedIdentityApplication (Node.js)
Remediation
-Upgrade github.com/Azure/azure-sdk-for-go/sdk/azidentity to version 1.6.0 or higher.
References
--
-
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- GitHub Commit -
- Microsoft Advisory -
- - - -
Template Injection
-- - - -
- - -
Detailed paths
- - - -- -
Overview
-dompurify is a DOM-only XSS sanitizer for HTML, MathML and SVG.
-Affected versions of this package are vulnerable to Template Injection in purify.js, due to inconsistencies in the parsing of XML and HTML tags. Executable code can be injected in HTML inside XML CDATA blocks.
PoC
-<![CDATA[ ><img src onerror=alert(1)> ]]>
- Remediation
-Upgrade dompurify to version 2.4.9, 3.0.11 or higher.
References
- - -- - - -