Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for Json formatted logs, force colours toggle #630

Closed
terev opened this issue Apr 30, 2020 · 0 comments · Fixed by #699
Closed

Option for Json formatted logs, force colours toggle #630

terev opened this issue Apr 30, 2020 · 0 comments · Fixed by #699
Assignees
Labels
enhancement New feature or request

Comments

@terev
Copy link
Contributor

terev commented Apr 30, 2020

Is your feature request related to a problem? Please describe.
The logs emitted by the gateway client and sensor are hard to parse and filter in the current textual format. Viewing logs in a log ingestion service is hard as the colour escape chars are included in the lines.

Describe the solution you'd like
An option that configures logging to output logs in Json records. Another option to disable colour in log output. I noticed that the logger is hardcoded to a textual format with colours here https://github.com/argoproj/argo-events/blob/master/common/logger.go#L41 . It seems easy enough to pass resolved options to this function.

Describe alternatives you've considered

Additional context
An example of hard to decipher gateway logs:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants