From f91e531fdc6c0322a189ae51632a21979024b611 Mon Sep 17 00:00:00 2001 From: yu-croco Date: Thu, 29 Feb 2024 19:27:29 +0900 Subject: [PATCH] fix: revert unnecessary diffs Signed-off-by: yu-croco --- charts/argo-cd/README.md | 2 +- charts/argo-cd/values.yaml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/argo-cd/README.md b/charts/argo-cd/README.md index 5cd2ca9b3..d1c952065 100644 --- a/charts/argo-cd/README.md +++ b/charts/argo-cd/README.md @@ -953,7 +953,7 @@ NAME: my-release | server.imagePullSecrets | list | `[]` (defaults to global.imagePullSecrets) | Secrets with credentials to pull images from a private registry | | server.ingress.annotations | object | `{}` | Additional ingress annotations | | server.ingress.aws.backendProtocolVersion | string | `"GRPC"` | Backend protocol version for the AWS ALB gRPC service | -| server.ingress.aws.serviceType | string | `"ClusterIP"` | Service type for the AWS ALB gRPC service | +| server.ingress.aws.serviceType | string | `"NodePort"` | Service type for the AWS ALB gRPC service | | server.ingress.controller | string | `"generic"` | Specific implementation for ingress controller. One of `generic`, `aws` or `gke` | | server.ingress.enabled | bool | `false` | Enable an ingress resource for the Argo CD server | | server.ingress.extraHosts | list | `[]` (See [values.yaml]) | The list of additional hostnames to be covered by ingress record | diff --git a/charts/argo-cd/values.yaml b/charts/argo-cd/values.yaml index cf47ff1b2..2bee3895b 100644 --- a/charts/argo-cd/values.yaml +++ b/charts/argo-cd/values.yaml @@ -2071,14 +2071,14 @@ server: ## Ref: https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/#aws-application-load-balancers-albs-and-classic-elb-http-mode aws: # -- Backend protocol version for the AWS ALB gRPC service - ## This tells AWS to send traffic from the ALB using gRPC. Can use HTTP2 as well + ## This tells AWS to send traffic from the ALB using gRPC. ## For more information: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/target-group-health-checks.html#health-check-settings backendProtocolVersion: GRPC # -- Service type for the AWS ALB gRPC service ## Can be of type NodePort or ClusterIP depending on which mode you are running. ## Instance mode needs type NodePort, IP mode needs type ClusterIP - ## Ref: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/how-it-works/#ingress-traffic - serviceType: ClusterIP + ## Ref: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/how-it-works/#ingress-traffic + serviceType: NodePort # Google specific options for Google Application Load Balancer # Applies only when `server.ingress.controller` is set to `gke`