[argo-cd] aws.backendProtocolVersion should be GRPC

[mikutas]

Describe the bug

Target health status of target group corresponding to this service becomes unhealthy because the value server.ingress.aws.backendProtocolVersion is HTTP2 (i.e. the target group's protocol version is HTTP2).
It causes argocd-server pod's "not ready" status in environment which benefit from pod readiness gate.

Target health status become healthy after setting server.ingress.aws.backendProtocolVersion to GRPC.

AWS docs:

• https://docs.aws.amazon.com/elasticloadbalancing/latest/application/target-group-health-checks.html#health-check-settings
  • 
• https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-protocol-version

Related helm chart

argo-cd

Helm chart version

6.4.1

To Reproduce

• Use aws-load-balancer-controller to expose argocd-server
• Set following values to argo-cd chart:
  • server.ingress.enabled: true
  • server.ingress.controller: aws

Expected behavior

Health check for target group is successful

Screenshots

No response

Additional context

My guess is alb.ingress.kubernetes.io/backend-protocol-version need not be configurable?

related issue: argoproj/argo-cd#8067

[yu-croco]

It's just my guess, but the default value is from sample in upstream, which means there's no deep meaning behind it
*I forgot where the doc was, but the values were the same as argo-helm's one.
And proper guide is explained here.

Anyway I think it's reasonable to change the default value of .server.ingress.aws.backendProtocolVersion and .server.ingress.aws.serviceType .
I will make PR for this.

[yu-croco]

*I forgot where the doc was, but the values were the same as argo-helm's one.

📝
it's here, referred in README.

[yu-croco]

It's just my guess, but the default value is from sample in upstream, which means there's no deep meaning behind it

The purpose of the default value is #2553 (comment) .

[mikutas]

just making sure 📝) serviceType doesn't matter with this issue | it's incorrect #2553 (comment)

[yu-croco]

just making sure 📝) serviceType doesn't matter with this issue

Thank you for correcting! 🙏