Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync issue with argo-cd helm chart 7.4.x #2883

Closed
jascsch opened this issue Aug 16, 2024 · 12 comments
Closed

Sync issue with argo-cd helm chart 7.4.x #2883

jascsch opened this issue Aug 16, 2024 · 12 comments
Labels
argo-cd bug Something isn't working

Comments

@jascsch
Copy link

jascsch commented Aug 16, 2024

Describe the bug

There is a sync issue with helm chart version 7.4.x so that apps are stuck in "OutOfSync" status.

Related helm chart

argo-cd

Helm chart version

7.4.x

To Reproduce

use the following manifest and try to sync the dapr app.

project: default
destination:
  server: 'https://kubernetes.default.svc'
  namespace: dapr
syncPolicy:
  syncOptions:
    - CreateNamespace=true
    - RespectIgnoreDifferences=true
ignoreDifferences:
  - kind: Secret
    name: dapr-trust-bundle
    namespace: dapr
    jsonPointers:
      - /data
sources:
  - repoURL: 'https://dapr.github.io/helm-charts/'
    targetRevision: 1.11.1
    helm:
      valueFiles:
        - $values/tools/dapr/values.yaml
      releaseName: dapr
      skipCrds: true
    chart: dapr
  - repoURL: 'https://git.xxx.com/org/gitops-cluster-dev.git'
    targetRevision: HEAD
    ref: values

Expected behavior

The sync status should be "Synced" instead of "OutOfSync"
The sync works perfectly fine with helm chart version 7.3.x

Screenshots

image

Additional context

No response

@jascsch jascsch added the bug Something isn't working label Aug 16, 2024
@yu-croco
Copy link
Collaborator

yu-croco commented Aug 16, 2024

Hi @jascsch , since it's related to Argo CD itself, you can get more help in upstream.
*argo-helm focuses on providing Helm chart for deploying Argo CD, but we don't handle the Argo CD itself (e.g. error logs, questions for specific behavior).

@jascsch
Copy link
Author

jascsch commented Aug 19, 2024

I created another git issue for Argo CD itself argoproj/argo-cd#19582

@mkilchhofer
Copy link
Member

mkilchhofer commented Sep 30, 2024

Chart version 7.4.0 is the first release of Argo CD 2.12 (.0):

Did you try a newer chart version with a newer appVersion, @jascsch ?

@jascsch
Copy link
Author

jascsch commented Oct 1, 2024

Hi @mkilchhofer yes, I already tested the latest release which is v2.12.4+27d1e64
The same issue here.

@jascsch
Copy link
Author

jascsch commented Oct 1, 2024

There is a significant sync behavior change between these versions.
It doesn`t matter how often I try to sync the app will always be out of sync.

image

@mkilchhofer
Copy link
Member

And what is the diff for this Dapr app? (From the screenshot I see that the "Auto sync is not enabled")

@jascsch
Copy link
Author

jascsch commented Oct 1, 2024

It is intended that auto sync is disabled.
image

@mkilchhofer
Copy link
Member

mkilchhofer commented Oct 1, 2024

Okay but from the screenshot you provided I cannot see a misbehaving of Argo CD.
What is the problem here? I am pretty sure that the halm chart of Dapr is using the non-idempotent function genPrivateKey, genCA and/or genSelfSignedCert:

https://github.com/dapr/dapr/blob/f5443ef6bcdaeaebc32c567a87ca1fc58808a518/charts/dapr/charts/dapr_sidecar_injector/templates/dapr_sidecar_injector_webhook_config.yaml#L9

@jascsch
Copy link
Author

jascsch commented Oct 2, 2024

behavior with 7.3.x (v2.11.7+e4a0246)

  • the dapr app stays in sync and does not show any diffs

behavior with 7.x.x (v2.12.4+27d1e64)

  • the dapr app stays out of sync and always shows a diff

The sync behaves completely differently between these versions and there is no workaround for this case.

@mkilchhofer
Copy link
Member

Did you hit refresh and/or hard refresh with the old version "7.3.x (v2.11.7+e4a0246)"?

As I already sent you the link to the used genSelfSignedCert function within the Dapr helm chart, I can say that this is by design. It might be possible that a minor bit changed in 2.12 but to analyze this, I recommend to file an issue in the upstream repository: https://github.com/argoproj/argo-cd/issues/new/choose

@jascsch
Copy link
Author

jascsch commented Oct 2, 2024

I already created an issue in upstream repository:
argoproj/argo-cd#19582

@mkilchhofer
Copy link
Member

Alright, lets close this helm chart issue then :)

@mkilchhofer mkilchhofer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants