Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed read-the-docs rendering #2277

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

kostis-codefresh
Copy link
Member

Signed-off-by: Kostis Kapelonis kostis@codefresh.io

Read the docs rendering as well as the drop-down version menu are broken because of readthedocs/readthedocs.org#9064 and mkdocs/mkdocs#2799

I fixed the issue by pinning the same versions mentioned in the argocd github repo

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 82.36% // Head: 82.38% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (527bc35) compared to base (d147af8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
+ Coverage   82.36%   82.38%   +0.01%     
==========================================
  Files         121      121              
  Lines       18476    18476              
==========================================
+ Hits        15218    15221       +3     
+ Misses       2471     2468       -3     
  Partials      787      787              
Impacted Files Coverage Δ
rollout/templateref.go 82.98% <0.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Go Published Test Results

1 772 tests   1 772 ✔️  2m 33s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 527bc35.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

E2E Tests Published Test Results

  1 files    1 suites   44m 53s ⏱️
89 tests 84 ✔️ 3 💤 2
91 runs  86 ✔️ 3 💤 2

For more details on these failures, see this check.

Results for commit 527bc35.

♻️ This comment has been updated with latest results.

@zachaller zachaller added the ready-for-review Ready for final review label Oct 4, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@leoluz leoluz merged commit 33ddaf5 into argoproj:master Oct 5, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
@zachaller zachaller added cherry-pick/release-1.3 cherry-pick-completed Used once we have cherry picked the PR to all requested releases labels Dec 8, 2022
zachaller pushed a commit that referenced this pull request Dec 8, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
zachaller pushed a commit that referenced this pull request Dec 13, 2022
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
@kostis-codefresh kostis-codefresh deleted the read-the-docs-fix branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.3 cherry-pick-completed Used once we have cherry picked the PR to all requested releases ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants