Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add example for istio-subset-split #2318

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

iam-veeramalla
Copy link
Member

@iam-veeramalla iam-veeramalla commented Oct 12, 2022

Signed-off-by: iam-veeramalla abhishek.veeramalla@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

While trying out istio with rollouts, I could not find any examples for istio-subset-split. However, there is an example for istio-mirroring.

This example would help someone who is starting with istio as traffic manager for argo-rollouts.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Go Published Test Results

1 778 tests   1 778 ✔️  2m 31s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 69a4dd0.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (69a4dd0) compared to base (da92e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18537    18537           
=======================================
  Hits        15342    15342           
  Misses       2410     2410           
  Partials      785      785           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 29m 26s ⏱️
  89 tests   84 ✔️ 3 💤 2
182 runs  172 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit 69a4dd0.

♻️ This comment has been updated with latest results.

@iam-veeramalla iam-veeramalla added ready-for-review Ready for final review and removed ready-for-review Ready for final review labels Oct 13, 2022
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@iam-veeramalla
Copy link
Member Author

@zachaller While trying out istio with rollouts, I could not find any examples for istio-subset-split. However, there is an example for istio-mirroring.

This example would help someone who is starting with istio as traffic manager for argo-rollouts.

Please check if you also think this should go in to the examples.

@zachaller zachaller merged commit c480f4d into argoproj:master Nov 7, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants