-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update GetTargetGroupMetadata to call DescribeTags in batches #2570
fix: update GetTargetGroupMetadata to call DescribeTags in batches #2570
Conversation
related to: argoproj#2569 Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
format Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
fddc148
to
7600681
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportBase: 81.59% // Head: 81.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 81.59% 81.60% +0.01%
==========================================
Files 130 130
Lines 19469 19481 +12
==========================================
+ Hits 15886 15898 +12
Misses 2766 2766
Partials 817 817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…rgoproj#2570) * update GetTargetGroupMetadata to call DescribeTags in batches related to: argoproj#2569 Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com> * Update defaults.go format Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com> --------- Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
…2570) * update GetTargetGroupMetadata to call DescribeTags in batches related to: #2569 Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com> * Update defaults.go format Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com> --------- Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com>
update GetTargetGroupMetadata to call DescribeTags in batches
DescribeTags allows up to 20 resources (ARNs) to be specified in a single call.
related to: #2569
closes: #2569
Signed-off-by: Chatchai Luangmanee 93616024+chatchai-outreach@users.noreply.github.com
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.