Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GetTargetGroupMetadata to call DescribeTags in batches #2570

Conversation

chatchai-outreach
Copy link
Contributor

@chatchai-outreach chatchai-outreach commented Feb 7, 2023

update GetTargetGroupMetadata to call DescribeTags in batches

DescribeTags allows up to 20 resources (ARNs) to be specified in a single call.

related to: #2569

closes: #2569

Signed-off-by: Chatchai Luangmanee 93616024+chatchai-outreach@users.noreply.github.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

related to: argoproj#2569

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Go Published Test Results

1 850 tests   1 850 ✔️  2m 32s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit 7600681.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 36m 12s ⏱️
  95 tests   90 ✔️ 3 💤 2
192 runs  184 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit 7600681.

♻️ This comment has been updated with latest results.

format

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
@chatchai-outreach chatchai-outreach force-pushed the chatchai-outreach/fix/aws-describe-tag-batch branch from fddc148 to 7600681 Compare February 7, 2023 22:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 81.59% // Head: 81.60% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7600681) compared to base (5c9bc03).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2570      +/-   ##
==========================================
+ Coverage   81.59%   81.60%   +0.01%     
==========================================
  Files         130      130              
  Lines       19469    19481      +12     
==========================================
+ Hits        15886    15898      +12     
  Misses       2766     2766              
  Partials      817      817              
Impacted Files Coverage Δ
utils/aws/aws.go 73.83% <85.00%> (+0.91%) ⬆️
utils/defaults/defaults.go 89.37% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit 24c9621 into argoproj:master Feb 8, 2023
@chatchai-outreach chatchai-outreach deleted the chatchai-outreach/fix/aws-describe-tag-batch branch February 8, 2023 21:53
chatchai-outreach added a commit to getoutreach/argoproj-argo-rollouts that referenced this pull request Feb 9, 2023
…rgoproj#2570)

* update GetTargetGroupMetadata to call DescribeTags in batches

related to: argoproj#2569

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>

* Update defaults.go

format

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>

---------

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
zachaller pushed a commit that referenced this pull request Feb 24, 2023
…2570)

* update GetTargetGroupMetadata to call DescribeTags in batches

related to: #2569

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>

* Update defaults.go

format

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>

---------

Signed-off-by: Chatchai Luangmanee <93616024+chatchai-outreach@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got TargetGroupVerifyError due to exceeding the limit of DescribeTags
2 participants