chore(deps): replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2681 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 133 133
Lines 20163 20163
=======================================
Hits 16460 16460
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
…/yaml Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".The package
github.com/ghodss/yamlis no longer actively maintained.sigs.k8s.io/yamlis a permanent fork ofgh.neting.cc/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.The notable change is that
github.com/ghodss/yamlusesgopkg.in/yaml.v2 v2.2.2, butsigs.k8s.io/yamlusesgopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.