Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly wrap Datadog API v2 request body (#2771) #2775

Merged
merged 2 commits into from
May 14, 2023
Merged

fix: properly wrap Datadog API v2 request body (#2771) #2775

merged 2 commits into from
May 14, 2023

Conversation

alexef
Copy link
Member

@alexef alexef commented May 11, 2023 •
edited
Loading

this is more inline with the docs at: https://docs.datadoghq.com/api/latest/metrics/?code-lang=curl#query-timeseries-data-across-multiple-products

fixes: #2771

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexef
Datadog: properly wrap request body
5eed95b 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef alexef changed the title bug: Datadog properly wrap request body. Fix #2771 bug: Datadog properly wrap request body (#2771) May 11, 2023
@alexef alexef requested a review from zachaller May 11, 2023 12:48
@alexef alexef changed the title bug: Datadog properly wrap request body (#2771) fix: Datadog properly wrap request body (#2771) May 11, 2023
@alexef alexef changed the title fix: Datadog properly wrap request body (#2771) fix: properly wrap Datadog API v2 request body (#2771) May 11, 2023
@alexef alexef mentioned this pull request May 11, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

Go Published Test Results

1 952 tests   1 952 ✔️  2m 36s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 861c38c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e66cd4) 81.64% compared to head (861c38c) 81.64%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2775   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         133      133           
  Lines       20177    20178    +1     
=======================================
+ Hits        16474    16475    +1     
  Misses       2849     2849           
  Partials      854      854
Impacted Files Coverage Δ
metricproviders/datadog/datadog.go 76.08% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 25m 55s ⏱️
  96 tests   87 ✔️   5 💤 4 ❌
392 runs  366 ✔️ 20 💤 6 ❌

For more details on these failures, see this check.

Results for commit 861c38c.

♻️ This comment has been updated with latest results.

@alexef
Use milliseconds in v2 calls to datadog
861c38c 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zachaller zachaller merged commit fef9cdb into argoproj:master May 14, 2023
@zachaller zachaller removed the ready-for-review Ready for final review label May 14, 2023
@alexef alexef deleted the datadog-v2-query branch May 15, 2023 07:15
zachaller pushed a commit that referenced this pull request May 24, 2023
@alexef @zachaller
fix: properly wrap Datadog API v2 request body (#2771) (#2775)
0322914 
* Datadog: properly wrap request body

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Use milliseconds in v2 calls to datadog

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

---------

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.5 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datadog v2 analysis ends in Error due to 500 from Datadog
2 participants
@alexef @zachaller