fix(controller): rollback should skip all steps to active rs within RollbackWindow #2953

amazingandyyy · 2023-08-11T22:23:49Z

Resolve #2939

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

github-actions · 2023-08-11T22:43:55Z

Go Published Test Results

2 044 tests 2 044 ✔️ 2m 39s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit 8b79f75.

♻️ This comment has been updated with latest results.

codecov · 2023-08-11T23:34:25Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f433582) 81.75% compared to head (8b79f75) 81.76%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         134      134           
  Lines       20377    20386    +9     
=======================================
+ Hits        16659    16668    +9     
  Misses       2861     2861           
  Partials      857      857

Files Changed	Coverage Δ
rollout/canary.go	`75.74% <100.00%> (+0.26%)`	⬆️
utils/replicaset/replicaset.go	`88.45% <100.00%> (+0.12%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-08-12T00:21:18Z

E2E Tests Published Test Results

    4 files     4 suites 3h 39m 8s ⏱️
102 tests   88 ✔️   6 💤   8 ❌
428 runs 385 ✔️ 24 💤 19 ❌

For more details on these failures, see this check.

Results for commit 8b79f75.

♻️ This comment has been updated with latest results.

amazingandyyy · 2023-08-17T00:03:31Z

@zachaller can you take a look on this, the issue is blocking us from using RollbackWindow in our production deployment.

amazingandyyy · 2023-08-18T18:53:52Z

@zachaller want to surface this again. thanks! Happy Friday!

Resolve argoproj#2939 Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

…active Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

…anary_rollback_to_active_rs_in_rollbackwindow

sonarqubecloud · 2023-08-31T14:28:23Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
47.8% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

…ollbackWindow (#2953) * fix(canary): skip steps when in rollback window and rs is still active Resolve #2939 Signed-off-by: Andy Chen <amazingandyyy@gmail.com> * test(canary): add case where rollback when in window and rs is still active Signed-off-by: Andy Chen <amazingandyyy@gmail.com> * test(replicaset): add test case for IsActive function Signed-off-by: Andy Chen <amazingandyyy@gmail.com> --------- Signed-off-by: Andy Chen <amazingandyyy@gmail.com> Co-authored-by: Yohan Belval <ybelval@turo.com> Co-authored-by: zachaller <zachaller@users.noreply.github.com>

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 3 times, most recently from 96303fa to 9921cba Compare August 11, 2023 22:26

amazingandyyy changed the title ~~fix: Canary rollback should skip all steps to active rs in RollbackWindow~~ fix(canary): rollback should skip all steps to active rs in RollbackWindow Aug 11, 2023

amazingandyyy changed the title ~~fix(canary): rollback should skip all steps to active rs in RollbackWindow~~ fix(canary): rollback should skip all steps to active rs within RollbackWindow Aug 11, 2023

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch from 9921cba to f80863b Compare August 11, 2023 22:31

amazingandyyy changed the title ~~fix(canary): rollback should skip all steps to active rs within RollbackWindow~~ fix(controller): rollback should skip all steps to active rs within RollbackWindow Aug 11, 2023

amazingandyyy marked this pull request as draft August 11, 2023 23:02

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 4 times, most recently from af059e3 to 262c1b4 Compare August 11, 2023 23:15

amazingandyyy marked this pull request as ready for review August 11, 2023 23:15

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 2 times, most recently from 9ce8241 to e8ac154 Compare August 11, 2023 23:20

amazingandyyy marked this pull request as draft August 11, 2023 23:37

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 2 times, most recently from 1ffc1ab to be07a73 Compare August 12, 2023 00:36

yohanb force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 2 times, most recently from c4187af to d42be54 Compare August 12, 2023 03:48

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 4 times, most recently from 521c90e to 7e7fd26 Compare August 16, 2023 18:06

amazingandyyy marked this pull request as ready for review August 16, 2023 20:01

yohanb force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch 2 times, most recently from 3b32b6b to c4940f1 Compare August 16, 2023 20:04

zachaller self-requested a review August 22, 2023 05:55

zachaller added the cherry-pick/release-1.6 label Aug 23, 2023

yohanb and others added 3 commits August 28, 2023 11:46

fix(canary): skip steps when in rollback window and rs is still active

8a22b81

Resolve argoproj#2939 Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

test(canary): add case where rollback when in window and rs is still …

ed450a8

…active Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

test(replicaset): add test case for IsActive function

d843ecc

Signed-off-by: Andy Chen <amazingandyyy@gmail.com>

amazingandyyy force-pushed the fix_canary_rollback_to_active_rs_in_rollbackwindow branch from 18ddda0 to d843ecc Compare August 28, 2023 18:46

Merge branch 'master' of github.com:argoproj/argo-rollouts into fix_c…

8b79f75

…anary_rollback_to_active_rs_in_rollbackwindow

zachaller approved these changes Aug 31, 2023

View reviewed changes

zachaller merged commit 8b0215d into argoproj:master Aug 31, 2023

zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Aug 31, 2023

yohanb deleted the fix_canary_rollback_to_active_rs_in_rollbackwindow branch November 24, 2023 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(controller): rollback should skip all steps to active rs within RollbackWindow #2953

fix(controller): rollback should skip all steps to active rs within RollbackWindow #2953

amazingandyyy commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

codecov bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 12, 2023 •

edited

Loading

amazingandyyy commented Aug 17, 2023

amazingandyyy commented Aug 18, 2023

sonarqubecloud bot commented Aug 31, 2023

fix(controller): rollback should skip all steps to active rs within RollbackWindow #2953

fix(controller): rollback should skip all steps to active rs within RollbackWindow #2953

Conversation

amazingandyyy commented Aug 11, 2023 • edited Loading

github-actions bot commented Aug 11, 2023 • edited Loading

Go Published Test Results

codecov bot commented Aug 11, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 12, 2023 • edited Loading

E2E Tests Published Test Results

amazingandyyy commented Aug 17, 2023

amazingandyyy commented Aug 18, 2023

sonarqubecloud bot commented Aug 31, 2023

amazingandyyy commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

codecov bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 12, 2023 •

edited

Loading