Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add the GOPATH to the go-to-protobuf command #3022

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

meeech
Copy link
Contributor

@meeech meeech commented Sep 6, 2023

This came up when trying to run the codegen. Need the GOPATH env var to be set.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
@meeech meeech marked this pull request as ready for review September 6, 2023 21:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@meeech meeech changed the title fix(Add the GOPATH to the go-to-protobuf command fix: Add the GOPATH to the go-to-protobuf command Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c5457e3) 81.75% compared to head (c5b752b) 81.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3022   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         134      134           
  Lines       20395    20395           
=======================================
  Hits        16674    16674           
  Misses       2865     2865           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Go Published Test Results

2 045 tests   2 045 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit c5b752b.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 27s ⏱️
102 tests   88 ✔️   6 💤   8
428 runs  384 ✔️ 24 💤 20

For more details on these failures, see this check.

Results for commit c5b752b.

@zachaller zachaller merged commit abb8474 into argoproj:master Sep 6, 2023
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
Add the GOPATH to the go-to-protobuf command

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Add the GOPATH to the go-to-protobuf command

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants