fix: sync notification controller configmaps/secrets first #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other informers Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
- Coverage 81.73% 81.71% -0.02%
==========================================
Files 134 134
Lines 20406 20406
==========================================
- Hits 16678 16675 -3
- Misses 2869 2871 +2
- Partials 859 860 +1
☔ View full report in Codecov by Sentry. |
zachaller
added a commit
that referenced
this pull request
Oct 5, 2023
sync notification controller configmaps/secrets first before starting other informers Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 13, 2023
…3075) sync notification controller configmaps/secrets first before starting other informers Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…3075) sync notification controller configmaps/secrets first before starting other informers Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…3075) sync notification controller configmaps/secrets first before starting other informers Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Philip Clark <philip.clark@iterable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced with self service notifications that due to the addition of the add to informer events. This created a race condition on controller startup. We would end up populating our notification api map with an empty value because it could not find the configmap because the informer was synced after starting up of the rollout informer which called defaultEventf function to create the add to informer events.
This PR changes the order that informers are started and waits for the notification informers to sync before starting other informers.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".