Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analysis): Add note about availability of new datadog v2 functionality #3131

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

meeech
Copy link
Contributor

@meeech meeech commented Oct 30, 2023

Was pointed out with the docs live from merge #2997, but we're still only at 1.6 this can be confusing for users.

Added the following:

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
@meeech meeech changed the title Add note about availability of new datadog v2 functionality fix(docs): Add note about availability of new datadog v2 functionality Oct 30, 2023
@meeech meeech changed the title fix(docs): Add note about availability of new datadog v2 functionality chore(docs): Add note about availability of new datadog v2 functionality Oct 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@meeech meeech changed the title chore(docs): Add note about availability of new datadog v2 functionality docs(analysis): Add note about availability of new datadog v2 functionality Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4471508) 81.85% compared to head (b60a915) 81.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3131   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         134      134           
  Lines       20556    20556           
=======================================
  Hits        16826    16826           
  Misses       2866     2866           
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 083 tests   2 083 ✔️  2m 48s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit b60a915.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 10s ⏱️
103 tests   89 ✔️   6 💤   8
432 runs  389 ✔️ 24 💤 19

For more details on these failures, see this check.

Results for commit b60a915.

@zachaller zachaller merged commit 3e940a6 into argoproj:master Oct 30, 2023
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants