Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs require build.os to be defined #3133

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

zachaller
Copy link
Collaborator

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller zachaller requested a review from leoluz October 30, 2023 21:16
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.1% 17.1% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e940a6) 81.85% compared to head (7feaf51) 81.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3133   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         134      134           
  Lines       20556    20556           
=======================================
  Hits        16826    16826           
  Misses       2866     2866           
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 083 tests   2 083 ✔️  2m 49s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 7feaf51.

@zachaller zachaller merged commit c83bf64 into argoproj:master Oct 30, 2023
21 checks passed
zachaller added a commit that referenced this pull request Oct 30, 2023
* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller added a commit that referenced this pull request Oct 30, 2023
* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller added a commit that referenced this pull request Oct 30, 2023
* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller added a commit that referenced this pull request Oct 30, 2023
* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller added a commit that referenced this pull request Oct 30, 2023
* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix read the docs build

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants