Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "fix: istio destionationrule subsets enforcement (#3126)" #3147

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: Revert "fix: istio destionationrule subsets enforcement (#3126)" #3147

merged 1 commit into from
Nov 2, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Nov 2, 2023 •
edited
Loading

This reverts commit 04e1119.

fixes: #3141

copilot:summary

@zachaller
Revert "fix: istio destionationrule subsets enforcement (argoproj#3126)"
e8e29ed 
This reverts commit 04e1119.

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller zachaller changed the title Revert "fix: istio destionationrule subsets enforcement (#3126)" fix: Revert "fix: istio destionationrule subsets enforcement (#3126)" Nov 2, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Go Published Test Results

2 083 tests   2 083 ✔️  2m 47s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit e8e29ed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 32m 46s ⏱️
103 tests   91 ✔️   6 💤   6 ❌
426 runs  388 ✔️ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit e8e29ed.

leoluz
leoluz approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 0593d92 into argoproj:master Nov 2, 2023
20 of 21 checks passed
zachaller added a commit that referenced this pull request Nov 2, 2023
@zachaller
fix: Revert "fix: istio destionationrule subsets enforcement (#3126)" (…
2184a07 
…#3147)

Revert "fix: istio destionationrule subsets enforcement (#3126)"

This reverts commit 04e1119.

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
dnguy078 added a commit to dnguy078/argo-rollouts that referenced this pull request Nov 28, 2023
@dnguy078
Revert "fix: Revert "fix: istio destionationrule subsets enforcement (a…
0f8d9aa 
…rgoproj#3126)" (argoproj#3147)"

This reverts commit 0593d92.
dnguy078 added a commit to dnguy078/argo-rollouts that referenced this pull request Nov 28, 2023
@dnguy078
Revert "fix: Revert "fix: istio destionationrule subsets enforcement (a…
5a6ccf4 
…rgoproj#3126)" (argoproj#3147)"

This reverts commit 0593d92.

Signed-off-by: Dennis Nguyen <dnguyen@nextdoor.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Istio traffic weight error
2 participants
@zachaller @leoluz