fix: canary step analysis run wasn't terminated as keep running after promote action being called. Fixes #3220

[oleksandr-codefresh]

fixes #3220

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

2 090 tests   2 090 ✔️  2m 49s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 1d0c273.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Tests Published Test Results

    4 files      4 suites   3h 31m 16s ⏱️
106 tests   94 ✔️   6 💤 6 ❌
432 runs  400 ✔️ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit 1d0c273.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1305129) 81.81% compared to head (1d0c273) 81.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
+ Coverage   81.81%   81.83%   +0.01%     
==========================================
  Files         135      135              
  Lines       20627    20629       +2     
==========================================
+ Hits        16876    16881       +5     
+ Misses       2880     2877       -3     
  Partials      871      871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zachaller]

Can we get a unit and/or e2e test for this?

[oleksandr-codefresh]

@zachaller was thinking about that, but you don't have any unit tests for this method (reconcileStepBasedAnalysisRun) ATM

[zachaller]

We do this function get's called via this https://github.com/argoproj/argo-rollouts/blob/master/rollout/analysis_test.go#L167 we spin up a controller there with a fake k8s client which will reconcile which ends up calling that function eventually.

[oleksandr-codefresh]

ok, will try to add

[oleksandr-codefresh]

@zachaller added

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
6.9% Duplication

[oleksandr-codefresh]

@zachaller Hi, could you pls take a look?