fix: make sure we use the updated rs when we write back to informer #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3237 +/- ##
==========================================
+ Coverage 81.81% 81.82% +0.01%
==========================================
Files 135 135
Lines 20625 20627 +2
==========================================
+ Hits 16874 16879 +5
+ Misses 2880 2877 -3
Partials 871 871 ☔ View full report in Codecov by Sentry. |
ashutosh16
pushed a commit
to ashutosh16/argo-rollouts
that referenced
this pull request
Dec 8, 2023
…rgoproj#3237) Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
emily-blixt-ck
pushed a commit
to emily-blixt-ck/argo-rollouts
that referenced
this pull request
Dec 8, 2023
…rgoproj#3237) Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added a commit
that referenced
this pull request
Dec 11, 2023
…3237) Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this in addScaleDownDelay as well this was just missing and so we are writing the same value we pass into the function instead of the updated rs.